Add nRF54H20 BICR generation support #19056

gmarull · 2024-11-25T13:00:57Z

No description provided.

NordicBuilder · 2024-11-25T13:01:35Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
zephyr	nrfconnect/sdk-zephyr@`ba1d06f`	nrfconnect/sdk-zephyr#2298	nrfconnect/sdk-zephyr#2298/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-11-25T13:06:42Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 24

Inputs:

Sources:

sdk-nrf: PR head: aa671758ae471c5647bae6f064635b7820251192
zephyr: PR head: dd6ea81bbd032f93a7ce276e0be3cbadc72e8edf

more details

sdk-nrf:

PR head: aa671758ae471c5647bae6f064635b7820251192
merge base: 9abba2029b75e5b4f8990f7b55b28817ed01a0e1
target head (main): 9abba2029b75e5b4f8990f7b55b28817ed01a0e1
Diff

zephyr:

PR head: dd6ea81bbd032f93a7ce276e0be3cbadc72e8edf
merge base: 43b638fd345eb5958923053655c483fff5cdab1f
target head (main): 7f8d857bf1f57b07e832d52263beaa23c91fef24
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (62)

CODEOWNERS
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── nrf54h
│  │  │  │  │  ├── ug_nrf54h20_custom_pcb.rst
│  │  │  │  │  │ ug_nrf54h20_suit_recovery.rst
samples
│  ├── suit
│  │  ├── flash_companion
│  │  │  │ prj.conf
│  │  ├── recovery
│  │  │  ├── prj.conf
│  │  │  ├── sysbuild
│  │  │  │  │ hci_ipc.conf
scripts
│  ├── west-commands.yml
│  ├── west_commands
│  │  ├── create_board
│  │  │  ├── config.yml
│  │  │  ├── ncs_create_board.py
│  │  │  ├── schema.json
│  │  │  ├── templates
│  │  │  │  ├── nrf54h
│  │  │  │  │  ├── Kconfig.board.jinja2
│  │  │  │  │  ├── Kconfig.defconfig.jinja2
│  │  │  │  │  ├── board-common.dtsi
│  │  │  │  │  ├── board-ipc_conf.dtsi
│  │  │  │  │  ├── board-memory_map.dtsi
│  │  │  │  │  ├── board-pinctrl.dtsi
│  │  │  │  │  ├── board-xip.dts.jinja2
│  │  │  │  │  ├── board.cmake.jinja2
│  │  │  │  │  ├── board.dts.jinja2
│  │  │  │  │  ├── board.yml.jinja2
│  │  │  │  │  ├── board_defconfig.jinja2
│  │  │  │  │  ├── board_twister.yml.jinja2
│  │  │  │  │  │ pre_dt_board.cmake
│  │  │  │ west-ncs-create-board-test.sh
│  │  ├── ncs-bicr.py
│  │  ├── ncs-board-actions.py
│  │  ├── utils
│  │  │  │ __init__.py
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf54h20dk
│  │  │  │  ├── bicr.json
│  │  │  │  ├── nrf54h20dk_bicr.dtsi
│  │  │  │  ├── nrf54h20dk_nrf54h20-common.dtsi
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.dts
│  ├── drivers
│  │  ├── clock_control
│  │  │  ├── clock_control_nrf2_common.c
│  │  │  ├── clock_control_nrf2_common.h
│  │  │  ├── clock_control_nrf2_fll16m.c
│  │  │  ├── clock_control_nrf2_hfxo.c
│  │  │  │ clock_control_nrf2_lfclk.c
│  │  ├── misc
│  │  │  ├── coresight
│  │  │  │  ├── Kconfig
│  │  │  │  │ nrf_etr.c
│  ├── dts
│  │  ├── bindings
│  │  │  ├── clock
│  │  │  │  ├── nordic,nrf54h-hfxo.yaml
│  │  │  │  │ nordic,nrf54h-lfxo.yaml
│  │  │  ├── gpio
│  │  │  │  ├── nordic,nrf-gpio.yaml
│  │  │  │  │ nordic,nrf-port-configs.yaml
│  │  │  ├── misc
│  │  │  │  │ nordic,nrf-bicr.yaml
│  │  ├── common
│  │  │  ├── nordic
│  │  │  │  │ nrf54h20.dtsi
│  ├── include
│  │  ├── zephyr
│  │  │  ├── drivers
│  │  │  │  ├── clock_control
│  │  │  │  │  │ nrf_clock_control.h
│  │  │  ├── shell
│  │  │  │  │ shell.h
│  ├── modules
│  │  ├── hal_nordic
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig.nrf_regtool
│  │  │  ├── nrf-regtool
│  │  │  │  │ nrf-regtoolConfig.cmake
│  ├── soc
│  │  ├── nordic
│  │  │  ├── nrf54h
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.defconfig.nrf54h20_cpuapp
│  │  │  │  ├── bicr
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  ├── bicr-schema.json
│  │  │  │  │  │ bicrgen.py
│  │  │  │ validate_base_addresses.c
│  ├── subsys
│  │  ├── logging
│  │  │  ├── Kconfig.misc
│  │  │  │ log_cmds.c
│  │  ├── shell
│  │  │  ├── CMakeLists.txt
│  │  │  │ Kconfig

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 1443
- sdk-zephyr test count: 6086
❌ Integration tests
- ✅ test-sdk-audio
- ❌ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nfc
- ✅ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-thread
- ✅ test-sdk-find-my
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ✅ test-sdk-sidewalk
- ❌ test-low-level
- ❌ test-sdk-dfu
- ⚠️ test-fw-nrfconnect-nrf-iot_cloud
- ⚠️ test-sdk-dfu

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-zigbee
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-11-26T10:53:15Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

scripts/west_commands/ncs-board-actions.py

greg-fer · 2024-11-26T14:15:10Z

@FrancescoSer , FYI

FrancescoSer

This PR needs documentation. The ug_nrf54h20_custom_pcb.rst file has to be updated.

gmarull · 2024-11-26T14:22:05Z

This PR needs documentation. The ug_nrf54h20_custom_pcb.rst file has to be updated.

Maybe the BICR file format? The west commands themselves are consumed by VS Code, even though theoretically, you can always use CLI

stale, please re-review

FilipZajdel

Looks good!

nordicjm · 2024-12-23T08:51:17Z

scripts/west_commands/ncs-board-actions.py

+    found_defconfig = None
+    for defconfig in board_dir.glob("Kconfig.*"):


not really the defconfig file

doc/nrf/app_dev/device_guides/nrf54h/ug_nrf54h20_custom_pcb.rst

So that we can start building the ncs-create-bicr command. Signed-off-by: Gerard Marull-Paretas <[email protected]>

Instead of the removed CONFIG_SOC_NRF54H20_GENERATE_BICR. Signed-off-by: Gerard Marull-Paretas <[email protected]>

When requesting the schema, return the actual schema and its initial state (empty). Signed-off-by: Gerard Marull-Paretas <[email protected]>

Add a new command to assist with BICR generation. Signed-off-by: Gerard Marull-Paretas <[email protected]>

Add a new command that allows to obtain a list of available board actions given a board directory. For now, only nRF54H boards have an action. Script may be improved in the future if list of commands grows. Signed-off-by: Gerard Marull-Paretas <[email protected]>

Add initial support for nRF54H20 based boards. Signed-off-by: Gerard Marull-Paretas <[email protected]>

When passed a JSON response to generate a board, return a list of actions or commands that should be performed afterwards. Signed-off-by: Gerard Marull-Paretas <[email protected]>

Add an action to invoke bicrgen.py to generate the BICR hex file. Signed-off-by: Gerard Marull-Paretas <[email protected]>

Update details on how BICR is generated. Signed-off-by: Gerard Marull-Paretas <[email protected]>

To be used with west commands implementing a jsonschema based protocol. Signed-off-by: Gerard Marull-Paretas <[email protected]>

Commands using a jsonschema based protocol will now report errors formatted in JSON. Signed-off-by: Gerard Marull-Paretas <[email protected]>

gmarull · 2025-01-02T11:26:17Z

Note: to be merged after upmerge, except e76c015

gmarull · 2025-02-13T14:01:02Z

Closing, other PRs have been opened instead. nRF54H20 BICR specifics or board generation will be added later if needed.

github-actions bot added the manifest label Nov 25, 2024

NordicBuilder added manifest-zephyr DNM labels Nov 25, 2024

gmarull requested review from FilipZajdel and kylebonnici November 25, 2024 14:01

gmarull force-pushed the bicrgen branch 2 times, most recently from ea2ce52 to 6960783 Compare November 26, 2024 10:36

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 26, 2024

gmarull force-pushed the bicrgen branch from 6960783 to 87a1849 Compare November 26, 2024 12:12

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 26, 2024

gmarull force-pushed the bicrgen branch 2 times, most recently from 63a7533 to c578f95 Compare November 26, 2024 12:39

FilipZajdel suggested changes Nov 26, 2024

View reviewed changes

scripts/west_commands/ncs-board-actions.py Outdated Show resolved Hide resolved

scripts/west_commands/ncs-board-actions.py Outdated Show resolved Hide resolved

FrancescoSer self-requested a review November 26, 2024 14:17

FrancescoSer previously requested changes Nov 26, 2024

View reviewed changes

gmarull force-pushed the bicrgen branch from c578f95 to 0d063a5 Compare November 26, 2024 14:20

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 26, 2024

gmarull requested review from FilipZajdel and FrancescoSer November 26, 2024 15:13

gmarull force-pushed the bicrgen branch from d42e229 to 89921ca Compare November 28, 2024 09:51

gmarull marked this pull request as ready for review November 28, 2024 09:52

gmarull requested review from a team as code owners November 28, 2024 09:52

gmarull force-pushed the bicrgen branch from 89921ca to 3159d57 Compare November 28, 2024 15:09

gmarull requested a review from a team November 28, 2024 15:09

gmarull requested a review from FilipZajdel December 16, 2024 09:27

gmarull force-pushed the bicrgen branch 3 times, most recently from 137f92d to 573051b Compare December 16, 2024 09:49

FilipZajdel approved these changes Dec 16, 2024

View reviewed changes

FrancescoSer modified the milestone: 2.9.0-nRF54H20 Dec 17, 2024

nordicjm approved these changes Dec 23, 2024

View reviewed changes

FrancescoSer requested changes Dec 23, 2024

View reviewed changes

gmarull requested a review from FrancescoSer January 2, 2025 11:24

gmarull added 11 commits January 2, 2025 12:25

manifest: pull BICR generation tooling

a38070b

So that we can start building the ncs-create-bicr command. Signed-off-by: Gerard Marull-Paretas <[email protected]>

samples: suit: use CONFIG_SOC_NRF54H20_GENERATE_BICR

e76c015

Instead of the removed CONFIG_SOC_NRF54H20_GENERATE_BICR. Signed-off-by: Gerard Marull-Paretas <[email protected]>

scripts: west_commands: create_board: return schema+state

41ee749

When requesting the schema, return the actual schema and its initial state (empty). Signed-off-by: Gerard Marull-Paretas <[email protected]>

scripts: west_commands: introduce ncs-bicr

f0ba5f5

Add a new command to assist with BICR generation. Signed-off-by: Gerard Marull-Paretas <[email protected]>

scripts: west_commands: create_board: initial support for nRF54H20

5bae20b

Add initial support for nRF54H20 based boards. Signed-off-by: Gerard Marull-Paretas <[email protected]>

scripts: west_commands: create_board: return list of post-actions

d1d0657

When passed a JSON response to generate a board, return a list of actions or commands that should be performed afterwards. Signed-off-by: Gerard Marull-Paretas <[email protected]>

scripts: west_commands: board_actions: add BICR generation action

5ffd6e4

Add an action to invoke bicrgen.py to generate the BICR hex file. Signed-off-by: Gerard Marull-Paretas <[email protected]>

doc: nrf: ug_nrf54h20_custom_pcb: update BICR details

2a97534

Update details on how BICR is generated. Signed-off-by: Gerard Marull-Paretas <[email protected]>

scripts: west_commands: add JSON excepthook

468f3b3

To be used with west commands implementing a jsonschema based protocol. Signed-off-by: Gerard Marull-Paretas <[email protected]>

scripts: west_commands: install JSON hook to commands using jsonschema

aa67175

Commands using a jsonschema based protocol will now report errors formatted in JSON. Signed-off-by: Gerard Marull-Paretas <[email protected]>

gmarull force-pushed the bicrgen branch from 4ff526a to aa67175 Compare January 2, 2025 11:26

FrancescoSer approved these changes Jan 15, 2025

View reviewed changes

shanthanordic added this to the 3.0.0 milestone Feb 3, 2025

This was referenced Feb 13, 2025

Adjust ncs-create-board to the agreed schema #20352

Merged

doc: nrf: ug_nrf54h20_custom_pcb: update BICR details #20353

Merged

gmarull closed this Feb 13, 2025

		found_defconfig = None
		for defconfig in board_dir.glob("Kconfig.*"):

Add nRF54H20 BICR generation support #19056

Add nRF54H20 BICR generation support #19056

Uh oh!

Conversation

gmarull commented Nov 25, 2024

Uh oh!

NordicBuilder commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

NordicBuilder commented Nov 26, 2024

Uh oh!

Uh oh!

Uh oh!

greg-fer commented Nov 26, 2024

Uh oh!

FrancescoSer left a comment

Choose a reason for hiding this comment

Uh oh!

gmarull commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FilipZajdel left a comment

Choose a reason for hiding this comment

Uh oh!

nordicjm Dec 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmarull commented Jan 2, 2025

Uh oh!

gmarull commented Feb 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

NordicBuilder commented Nov 25, 2024 •

edited

Loading

NordicBuilder commented Nov 25, 2024 •

edited

Loading

gmarull commented Nov 26, 2024 •

edited

Loading